This has also become one of my highest priority issues that I would like fixed before others I've raised because now I have an incorrectly generated hbm.xml file that needs to be manually edited each time I regenerate my code.

I have classes foo1 and foo2. foo1 has a foreign key to foo2. foo2 had a default column name of foo2_id but I changed it to foo2id. I expected the foreign key on foo1 to automatically refer to foo2id instead of foo2_id. To workaround this I added a hibernate tag on the relationship between foo1 and foo2 but that is cumbersome to do for every relationship.

Can this be corrected?

Thanks.

Hi,

Do I understand you correctly if I think that you added a @Column tag to the id attribute in class foo2 to change its column name, and then you want the foreign key to use that @Column tag?

Regards,
Lars

Yes your understanding is correct. In my scenario foo1 is called ScanStock and foo2 is called TimeframeDefinition. Here are their hbm.xml files:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

<!-- Generated by HiberObjects. DO NOT EDIT! -->
<hibernate-mapping>
<class name='com.pinkwater.trader.server.ScanStock' table='scanstoc'>
<id name='id' type='long' column='scanstocid'>
<generator class='native' />
</id>
<set name='bar' table='tb_scan_stock_bar'>
<key column='scanstocid' foreign-key='fk_scan_stock_bar_key'/>
<many-to-many class='com.pinkwater.trader.server.Bar' foreign-key='fk_scan_stock_bar' column='bar_id' />
</set>
<set name='scannedParameter' table='tb_scan_stock_scan_parameter'>
<key column='scanstocid' foreign-key='fk_scan_stock_scan_parameter_key'/>
<many-to-many class='com.pinkwater.trader.server.ScanParameter' foreign-key='fk_scan_stock_scanned_parameter' column='scanned_parameter_id' />
</set>
<many-to-one name='stockDefinition' class='com.pinkwater.trader.server.StockDefinition' not-null='true' cascade='save-update' foreign-key='fk_scan_stock_stock_definition_id'>
<column name='stock_definition_id'/>
</many-to-one>
<many-to-one name='timeframeDefinition' class='com.pinkwater.trader.server.TimeframeDefinition' not-null='true' cascade='save-update' foreign-key='fk_scan_stock_timeframe_definition_id'>
<column name='timeframe_definition_id'/>
</many-to-one>
</class>
</hibernate-mapping>

and:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

<!-- Generated by HiberObjects. DO NOT EDIT! -->
<hibernate-mapping>
<class name='com.pinkwater.trader.server.TimeframeDefinition' table='timefrmdefn'>
<id name='id' type='long' column='timefrmdefnid'>
<generator class='native' />
</id>
<property name='description' type='string' column='description'>
</property>
</class>
</hibernate-mapping>

I tried to add a Hibernate tag on the association to change the column name from scan_id to scanid but this only changed the ScanPage.hbm.xml but I expected the Scan.hbm.xml to similarly change. Now Scan.hbm.xml is incorrect and HibernateHelper fails to load scan.hbm.xml, the two hbm.xml files follow:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

<!-- Generated by HiberObjects. DO NOT EDIT! -->
<hibernate-mapping>
<class name='com.pinkwater.trader.server.Scan' table='scan'>
<id name='id' type='long' column='scanid'>
<generator class='native' />
</id>
<property name='tradingDate' type='timestamp' column='traddate'>
</property>
<many-to-one name='scanDefinition' class='com.pinkwater.trader.server.ScanDefinition' not-null='true' cascade='save-update' foreign-key='fk_scan_scan_definition_id'>
<column name='scan_definition_id'/>
</many-to-one>
<set name='scanPages' inverse='true'>
<key column='scan_id' foreign-key='fk_scan_page_scan_key'/>
<one-to-many class='com.pinkwater.trader.server.ScanPage' />
</set>
</class>
</hibernate-mapping>

and:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

<!-- Generated by HiberObjects. DO NOT EDIT! -->
<hibernate-mapping>
<class name='com.pinkwater.trader.server.ScanPage' table='scanpage'>
<id name='id' type='long' column='scanpageid'>
<generator class='native' />
</id>
<property name='pageNumber' type='integer' column='pagenumb'>
</property>
<set name='scannedStocks' inverse='true'>
<key column='scan_page_id' foreign-key='fk_scan_stock_scan_page_key'/>
<one-to-many class='com.pinkwater.trader.server.ScanStock' />
</set>
<property name='filename' type='string' column='filename'>
</property>
<many-to-one name='scan' class='com.pinkwater.trader.server.Scan' not-null='true' cascade='save-update' foreign-key='fk_scan_page_scan_id' column='scanid'>
</many-to-one>
</class>
</hibernate-mapping>

Hi,

I think I have fixed what you want. Please try it by modifying hbm.template (see the following post) as follows:
This is the Groovy code that generates the foreign-key for set.

If I then create a @hibernate tag with column=custid on the Customer id attribute, I get the following hbm.xml:I know it is a steep learning curve to modify this template, but if you want full control of the generated database schema, this is how to do it.

My personal view is that these details aren't so important, as long as we can map the database to Java objects. I think these Hibernate features are mostly meant for mapping existing database schemas to Java, not when we generate the database from the Java classes. But I'm sure all DBA's will disagree with me ;-)

Regards,
Lars

Hi Lara,

I downloaded the hbm.template and modified it according to your post but the code generation is still the same so I am guessing that I have placed the file in the wrong package???

From a usability point of view it seems natural that if I change the column name for an attribute that all foreign keys that utilise it should also use the new column name. Can you make that an automatic feature in the next release?

Thanks,
Stephen

Hi Stephen,

If you upgraded to 2.0.7 you will get the new hbm.template in there, so you don't need to place it in your project. So this will be the default behavior for all projects that don't override the hbm.template. But the right place to put it is in the project root.

Have you tried Save All (in the HiberObjects popup menu) after upgrading/changing hbm.template?

If not, perhaps I didn't understand exactly what you're after. Could you post the exact classes and tags you have designed (or mail a screenshot to eclipse@objectgeneration.com) and the exact XML you want generated.

/Lars